Auth internal rewrite #1239
Auth internal rewrite #1239
Conversation
Update auth internals to support returning Future object for the new API while also support returning Future<User*> objects for the deprecated API on iOS. Changes does not include the new Future methods.
Removes the need for User objects to be stored in AuthData, unlocking ability for there to be more than one User object at a time. Continues to store a User in Auth, though, to maintain the implementation of the newly deprecated methods which return a User*. Added a RetainUser integration test.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| UserInternal* user_internal_; | ||
| }; | ||
| | ||
| } // namespace auth |
There was a problem hiding this comment.
📝 Documentation issue: [3 lines down] warning: More #endif's than #if's found.
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @CreateUserWithEmailAndPassword instead. | ||
| /// |
There was a problem hiding this comment.
📝 Documentation issue: warning: Found unknown command '\CreateUserWithEmailAndPassword'
| ~Auth(); | ||
| | ||
| /// @deprecated This is a deprecated method. Please use @current_user instead. | ||
| /// |
There was a problem hiding this comment.
📝 Documentation issue: warning: Found unknown command '\current_user'
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @SignInAndRetrieveDataWithCredential instead. | ||
| /// |
There was a problem hiding this comment.
📝 Documentation issue: warning: Found unknown command '\SignInAndRetrieveDataWithCredential'
| const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use @SignInWithCredential | ||
| /// instead. |
There was a problem hiding this comment.
📝 Documentation issue: warning: Found unknown command '\SignInWithCredential'
| | ||
| /// @deprecated | ||
| /// | ||
| /// Get results of the most recent call to @ref ReauthenticateAndRetrieveData. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateAndRetrieveData' for \ref command
| ReauthenticateAndRetrieveDataLastResult_DEPRECATED() const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @ref ReauthenticateWithProvider(FederatedAuthProvider*) instead. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateWithProvider(FederatedAuthProvider*)' for \ref command
| FIREBASE_DEPRECATED Future<SignInResult> LinkWithProvider_DEPRECATED( | ||
| FederatedAuthProvider* provider); | ||
| | ||
| /// @deprecated This is a deprecated method. Please use @ref Unlink(const |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
| | ||
| /// @deprecated | ||
| /// | ||
| /// Get results of the most recent call to @ref Unlink. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
| FIREBASE_DEPRECATED Future<User*> UnlinkLastResult_DEPRECATED() const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @ref UpdatePhoneNumberCredential(const PhoneAuthCredential&) instead. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'UpdatePhoneNumberCredential(const PhoneAuthCredential&)' for \ref command
| Closing PR to rename branch. |
1 participant
Description
Feature Branch.
Do not merge.
Testing
Type of Change
Place an
xthe applicable box: