Firestore: Add absl header-only support for Android builds #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…the android build _still_ uses cmake 3.6
…work in cmake 3.6
…ed for building firebase-ios-sdk
dconeybe changed the title …ECTORY does not exist
…irectory exists, before assuming that it exists
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR enables the Firestore component to use header-only components of absl when targeting Android. This was achieved by downloading the firebase-ios-sdk and calling cmake on it to trigger the download of absl.
This PR also includes some broader-reaching changes:
FIREBASE_FLATC_CMAKE_COMMANDcmake cache variables is renamed toFIREBASE_HOST_CMAKE_COMMAND, since it's no longer exclusively used when building flatc, but also when running cmake on the firebase-ios-sdk during Android builds.execute_process_ex()is added in the new filecmake/execute_process_ex.cmake, which simply calls the built-inexecute_process()function but (a) adds some logging around it and (b) checks the exit code of the process and fails the build if it is non-zero.integration_test_internalno longer downloads its own copy of absl, but rather uses the one downloaded by the main build.