Skip to content

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Oct 13, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Use vcpkg again to fix link errors in our iTests CI built against the packaged SDK.

Example issues in the build: Integration CI


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

iTest successful runs without Packaged SDK

iTest successful runs from Packaged SDK

Both runs have test failures, but at least they build!


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@DellaBitta DellaBitta changed the title Fix iTests on Packaged Builds - readd vcpkg Fix iTests on Packaged Builds - add vcpkg Oct 13, 2022
@DellaBitta DellaBitta marked this pull request as ready for review October 13, 2022 18:21
@DellaBitta DellaBitta requested a review from a-maurice October 13, 2022 19:11
@DellaBitta DellaBitta closed this Oct 13, 2022
@DellaBitta DellaBitta deleted the ddb/itest_fix branch November 10, 2022 16:05
@firebase firebase locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants