CMakeLists.txt: Add FIREBASE_FLATC_CMAKE_COMMAND #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…en building flatc
… a specific cmake to use for flatc
dconeybe changed the title cmake when building flatcFIREBASE_FLATC_CMAKE_COMMAND dconeybe added the tests-requested: quick 
github-actions bot added tests: in-progress 
❌ Integration test FAILEDRequested by @dconeybe on commit 88ad013
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger bot removed the tests: in-progress dconeybe added the tests-requested: quick github-actions bot added tests: in-progress firebase-workflow-trigger bot removed the tests: in-progress dconeybe added tests-requested: quick github-actions bot added tests: in-progress firebase-workflow-trigger bot removed the tests: in-progress dconeybe added tests-requested: quick github-actions bot added tests: in-progress firebase-workflow-trigger bot removed the tests: in-progress 
cynthiajoan previously approved these changes Oct 19, 2022
github-actions bot dismissed cynthiajoan’s stale review 🍞 Dismissed stale approval on external PR.
cynthiajoan approved these changes Oct 19, 2022
github-actions bot added tests: in-progress firebase-workflow-trigger bot removed the tests: in-progress 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a new cmake cache variable,
FIREBASE_FLATC_CMAKE_COMMAND, which can be used to specify the path of the cmake executable to use when compiling flatc. If not specified, it uses cmake from the PATH. This works just fine most of the time; however, some build environments (such as building from CLion) do not have cmake in the PATH. In these cases, a workaround is to specify the absolute path to the cmake executable using this new cache variable.