AppCheck API Proposal - Draft #1067
Conversation
…roviderFactory method that also sets token auto refresh
| class AppCheck { | ||
| public: | ||
| /** | ||
| * Gets the instance of {@code AppCheck} associated with the given {@link |
There was a problem hiding this comment.
(it's just firebase::App)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| | ||
| ::firebase::app_check::AppCheckProvider* CreateProvider( | ||
| const ::firebase::App& app) override; | ||
| |
There was a problem hiding this comment.
Redundant blank line at the end of a code block should be deleted.
| * FirebaseApp} instance, or creates one if none already exists. | ||
| */ | ||
| AppCheckProvider* CreateProvider(const App& app) override; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Could not find a newline character at the end of the file.
| virtual AppCheckProvider* CreateProvider(const App& app) = 0; | ||
| } | ||
| | ||
| /// @brief Firebase App Check object. |
There was a problem hiding this comment.
Line ends in whitespace. Consider deleting these extra spaces.
| * the token or with an error code and error message. | ||
| */ | ||
| virtual void GetToken( | ||
| std::function<void(AppCheckToken, int, const std::string&)> |
There was a problem hiding this comment.
Add #include <string> for string
| * FirebaseApp} instance, or creates one if none already exists. | ||
| */ | ||
| AppCheckProvider* CreateProvider(const App& app) override; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Could not find a newline character at the end of the file.
| * FirebaseApp} instance, or creates one if none already exists. | ||
| */ | ||
| AppCheckProvider* CreateProvider(const App& app) override; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Could not find a newline character at the end of the file.
| * FirebaseApp} instance, or creates one if none already exists. | ||
| */ | ||
| AppCheckProvider* CreateProvider(const App& app) override; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Could not find a newline character at the end of the file.
| // limitations under the License. | ||
| | ||
| /** | ||
| * Implementation of an {@link AppCheckProviderFactory} that builds {@link |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve link to 'AppAttestCheckProvider' for \link command
| | ||
| /** | ||
| * Implementation of an {@link AppCheckProviderFactory} that builds {@link | ||
| * AppAttestCheckProvider}s. This is the default implementation. |
There was a problem hiding this comment.
📝 Documentation issue: warning: Unexpected end of comment while inside link command
| */ | ||
| static AppAttestCheckProviderFactory* GetInstance(); | ||
| | ||
| /** |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve link to 'AppCheckProvider' for \link command
| static AppAttestCheckProviderFactory* GetInstance(); | ||
| | ||
| /** | ||
| * Gets the {@link AppCheckProvider} associated with the given {@link |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve link to 'FirebaseApp' for \link command
| | ||
| /** | ||
| * Gets the {@link AppCheckProvider} associated with the given {@link | ||
| * FirebaseApp} instance, or creates one if none already exists. |
There was a problem hiding this comment.
📝 Documentation issue: warning: Unexpected end of comment while inside link command
| | ||
| /** | ||
| * Gets the {@link AppCheckProvider} associated with the given {@link | ||
| * FirebaseApp} instance, or creates one if none already exists. |
There was a problem hiding this comment.
📝 Documentation issue: warning: Unexpected end of comment while inside link command
| public: | ||
| /** | ||
| * Gets an instance of this class for installation into a {@link | ||
| * firebase::app_check::AppCheck} instance. |
There was a problem hiding this comment.
📝 Documentation issue: warning: Unexpected end of comment while inside link command
| completion_callback) = 0; | ||
| } | ||
| | ||
| /** Interface for a factory that generates {@link AppCheckProvider}s. */ |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve link to 'AppCheckProvider' for \link command
| public: | ||
| virtual ~AppCheckProviderFactory(); | ||
| /** | ||
| * Gets the {@link AppCheckProvider} associated with the given {@link |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve link to 'FirebaseApp' for \link command
| virtual ~AppCheckProviderFactory(); | ||
| /** | ||
| * Gets the {@link AppCheckProvider} associated with the given {@link | ||
| * FirebaseApp} instance, or creates one if none already exists. |
There was a problem hiding this comment.
📝 Documentation issue: warning: Unexpected end of comment while inside link command
| This PR was just to show the headers as part of the API proposal. A separate PR will merge the finalized headers. |
3 participants
Description
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.