Skip to content

Android GHA workflow #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 30, 2020
Merged

Android GHA workflow #105

merged 6 commits into from
Jul 30, 2020

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jul 29, 2020 •
edited
Loading

Add Android as a GHA CI worfklow.

  • added android.yml to our workflows
  • fixed an analytics build issue which now news to include play-services-base as an implementation dependency.
  • there's a lint failure in a firestore dependency. Disabling abortOnError for that gradle build target for now. I've added an internal issue to the backlog to circle back on this issue later.
@DellaBitta DellaBitta marked this pull request as ready for review July 29, 2020 20:08
jonsimantov
jonsimantov reviewed Jul 29, 2020
View reviewed changes
jonsimantov
jonsimantov approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though just a heads up I may change the way it decides whether to install ccache as part of my change. :)
@DellaBitta DellaBitta merged commit 608adb6 into dev Jul 30, 2020
@DellaBitta DellaBitta deleted the feature/gha-android-builds branch July 30, 2020 19:58
@DellaBitta
Copy link
Contributor Author

DellaBitta commented Jul 30, 2020

Looks good, though just a heads up I may change the way it decides whether to install ccache as part of my change. :)

That's ok!
@firebase firebase locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

4 participants

@DellaBitta @vimanyu @jonsimantov @googlebot