Skip to content

Fix cleanup of query tags from get #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix cleanup of query tags from get #4570

wants to merge 11 commits into from

Conversation

@maneesht
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 18, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.09% (ff558a4) to 50.06% (373a981) by -0.03%.

    FilenameBase (ff558a4)Merge (373a981)Diff
    DoubleNode.java88.24%100.00%+11.76%
    SyncTree.java56.89%57.02%+0.12%
    ViewProcessor.java92.10%91.79%-0.30%
    WebsocketConnection.java35.03%32.77%-2.26%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rS9qdlZM3Q.html
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023 •
edited
Loading

Unit Test Results

  27 files   -    375    27 suites   - 375   23s ⏱️ - 18m 8s
401 tests  - 4 360  399 ✔️  - 4 339  2 💤  - 20  0 ❌  - 1 
401 runs   - 4 376  399 ✔️  - 4 355  2 💤  - 20  0 ❌  - 1 

Results for commit 435f3c6. ± Comparison against base commit ff558a4.

♻️ This comment has been updated with latest results.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 18, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (ff558a4) and merge commit (373a981).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wOg0w6CzoV.html
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 18, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileff558a4373a981DiffSignificant (?)
    p10160 ±6 ms166 ±12 ms+6.10 ms (+3.8%)NO
    p25166 ±6 ms172 ±14 ms+6.92 ms (+4.2%)NO
    p50172 ±7 ms180 ±17 ms+8.14 ms (+4.7%)NO
    p75180 ±11 ms190 ±23 ms+10.3 ms (+5.7%)NO
    p90189 ±16 ms200 ±26 ms+10.5 ms (+5.6%)NO

    20 test runs in comparison
    CommitTest Runs
    ff558a4
    • 2023-01-18_16:36:32.652295_Eprh
    • 2023-01-18_16:36:32.656403_jfsm
    • 2023-01-18_16:36:32.656415_qPsr
    • 2023-01-18_16:36:32.656422_eCvd
    • 2023-01-18_16:36:32.656427_wzdO
    • 2023-01-18_16:36:32.656435_OsKs
    • 2023-01-18_16:36:32.656440_POgA
    • 2023-01-18_16:36:32.656446_Uxmv
    • 2023-01-18_16:36:32.656455_vOls
    • 2023-01-18_16:36:32.656460_QEsO
    373a981
    • 2023-01-18_19:13:06.169292_JSzv
    • 2023-01-18_19:13:06.170674_EVvq
    • 2023-01-18_19:13:06.170685_nowd
    • 2023-01-18_19:13:06.170690_rTNH
    • 2023-01-18_19:13:06.170696_IZhU
    • 2023-01-18_19:13:06.170702_xbQe
    • 2023-01-18_19:13:06.170708_wFhj
    • 2023-01-18_19:13:06.170713_BLUw
    • 2023-01-18_19:13:06.170724_vRBr
    • 2023-01-18_19:13:06.170729_PxXj
    redfin-30
    Percentileff558a4373a981DiffSignificant (?)
    p10186 ±6 ms207 ±5 ms+21.2 ms (+11.4%)MAYBE
    p25191 ±6 ms212 ±6 ms+21.1 ms (+11.0%)MAYBE
    p50199 ±7 ms220 ±8 ms+21.0 ms (+10.6%)MAYBE
    p75207 ±8 ms229 ±9.6 ms+22.3 ms (+10.8%)NO
    p90214 ±9.9 ms241 ±18 ms+27.2 ms (+12.7%)NO

    20 test runs in comparison
    CommitTest Runs
    ff558a4
    • 2023-01-18_16:36:32.652295_Eprh
    • 2023-01-18_16:36:32.656403_jfsm
    • 2023-01-18_16:36:32.656415_qPsr
    • 2023-01-18_16:36:32.656422_eCvd
    • 2023-01-18_16:36:32.656427_wzdO
    • 2023-01-18_16:36:32.656435_OsKs
    • 2023-01-18_16:36:32.656440_POgA
    • 2023-01-18_16:36:32.656446_Uxmv
    • 2023-01-18_16:36:32.656455_vOls
    • 2023-01-18_16:36:32.656460_QEsO
    373a981
    • 2023-01-18_19:13:06.169292_JSzv
    • 2023-01-18_19:13:06.170674_EVvq
    • 2023-01-18_19:13:06.170685_nowd
    • 2023-01-18_19:13:06.170690_rTNH
    • 2023-01-18_19:13:06.170696_IZhU
    • 2023-01-18_19:13:06.170702_xbQe
    • 2023-01-18_19:13:06.170708_wFhj
    • 2023-01-18_19:13:06.170713_BLUw
    • 2023-01-18_19:13:06.170724_vRBr
    • 2023-01-18_19:13:06.170729_PxXj

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HryuSvmejg/index.html
@maneesht maneesht marked this pull request as ready for review January 18, 2023 18:56
@maneesht maneesht requested a review from jmwski January 18, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main-merge-ack size/L

3 participants

@maneesht @google-oss-bot @jmwski