RTDB Optimization: Set initial capacity of the string builder #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

jsdt wants to merge 1 commit into main from jsdt/string-builder-capacity

Contributor

jsdt commented May 5, 2022

This is a minor optimization to reduce some allocations in the RTDB client.

Set initial capacity of the string builder

27ca577

google-oss-bot added the size/XS label

Contributor

google-oss-bot commented May 5, 2022

Coverage Report ¹

Affected Products

firebase-database
Overall coverage changed from 50.21% (889bf9a) to 50.16% (38b4c2c) by -0.05%.
Filename Base (889bf9a) Merge (38b4c2c) Diff
BooleanNode.java 92.31% 100.00% +7.69%
ChildChangeAccumulator.java 96.67% 83.33% -13.33%

Test Logs

Notes

Commit (38b4c2c) is created by Prow via merging PR base commit (889bf9a) and head commit (27ca577).
Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

https://storage.googleapis.com/firebase-sdk-metric-reports/TqWscbyprS.html

Contributor

google-oss-bot commented May 5, 2022

Size Report ¹

Affected Products

firebase-database
Type Base (889bf9a) Merge (38b4c2c) Diff
aar 488 kB 488 kB +63 B (+0.0%)
apk (release) 1.14 MB 1.14 MB +96 B (+0.0%)

Test Logs

Notes

Commit (38b4c2c) is created by Prow via merging PR base commit (889bf9a) and head commit (27ca577).

https://storage.googleapis.com/firebase-sdk-metric-reports/A2a8nf78lt.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment