Skip to content

Conversation

@mohammadJaliliTorkamani
Copy link

added new assertion:
assert issuer != null && !issuer.isEmpty() : "Issuer must not be null or empty.";

to the method "setIssuer" located at \src\main\java\com\google\firebase\auth\OidcProviderConfig.java

This assertion would prevent the application from running when the issuer variable is null or empty.

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.
@google-cla
Copy link

google-cla bot commented Jul 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lahirumaramba
Copy link
Member

Hi @mohammadJaliliTorkamani the existing code covers the same behavior. Did I miss anything here?

@mohammadJaliliTorkamani mohammadJaliliTorkamani closed this by deleting the head repository Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants