Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
added assertion message to two of the assertion:
assert (now == 0)
and
assert (result.length() == 20)
located at src/main/java/com/google/firebase/database/utilities/PushIdGenerator.java
to make program debugging more efficient.
As well, a new assertion was added to check the value of the variable "lastRandChars" as follows:
assert (lastRandChars[i] >= 0 && lastRandChars[i] < 64) : "Number generated by Random should be between 0 and 63";
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.