Handling errors thrown by Transaction.Handler.onComplete() #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…rrently these errors are simply swallowed and ignored. This PR handles them and logs.
mikelehen approved these changes Sep 12, 2017
There was a problem hiding this comment.
I think this looks fine. Really, this should probably return a Task or something, but probably not worth the churn.
FWIW, I wonder if there may be a similar problem with listeners. I think on Android we counted on exceptions on the EventTarget thread crashing the app...
| It looks like the same applies for data events. They are also scheduled on |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently these errors are simply swallowed and ignored. This PR handles them by logging the errors. Resolves #69.