Proper handling of exceptions when verifying ID tokens #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikelehen suggested changes Sep 6, 2017
| "https://identitytoolkit.googleapis.com/google.identity.identitytoolkit.v1.IdentityToolkit"; | ||
| private static final String ERROR_CODE = "ERROR_INVALID_CREDENTIAL"; | ||
| private static final String ERROR_INVALID_CREDENTIAL = "ERROR_INVALID_CREDENTIAL"; | ||
| private static final String ERROR_RUNTIME_EXCEPTION = "ERROR_RUNTIME_EXCEPTION"; |
There was a problem hiding this comment.
Are there more of these? Should they all be defined in a single place?
There was a problem hiding this comment.
There are few more in FirebaseUserManager. I don't feel like there's enough of them to start extracting them into one place. WDYT? Perhaps introduce a new internal.Constants class, which would hold all shared constants?
There was a problem hiding this comment.
I think in general it's useful to centralize error codes, for auditing and documentation purposes and whatnot. But I don't feel strongly that that needs to happen in this PR. So feel free to just consider it for the future.
mikelehen approved these changes Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.