SLF4J Integration #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikelehen approved these changes Jul 7, 2017
| * diagnostic logging, and {@link Logger.Level#NONE NONE} to disable all logging. | ||
| * | ||
| * @param logLevel The desired minimum log level | ||
| * @deprecated Use SLF4J-based logging. This method will be removed in a future release. |
There was a problem hiding this comment.
Is there some way we can be more specific / helpful than "Use SLF4J-based logging" ? Maybe it would be something like "Use SLF4J-based logging (e.g. just add slf4j-simple to your classpath to log to STDERR)." ?
On that note, we'll want to communicate this change to the support folks as well so they know how to ask developers to provide logs going forward.
There was a problem hiding this comment.
Done. Updated the text and added a link to SLF4J user manual.
| /** | ||
| * Legacy logging interface for database implementation. This class attempts to reconcile SLF4J | ||
| * with the old logging implementation of Admin SDK. When SLF4J is available, logs using that | ||
| * API. Otherwise falls back to the old logging implementation. This class will removed in a |
There was a problem hiding this comment.
I assume we could just log to both but we're avoiding that because it would potentially result in duplicate logs for people? Perhaps worth spelling that out in the comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We wish to use SLF4J as the logging interface in the Admin SDK.
Logclass in the internal package with calls to SLF4JLogWrapperto log to SLF4J when available, and log to the old interface when not. This is a temporary solution to avoid the breaking change. When we remove the deprecated logging stuff in the future, we can get rid of this as well.