Skip to content

Conversation

@utam0k
Copy link

@utam0k utam0k commented Feb 26, 2021

I challenged 9862c55(tag: v7.1.0) tests on my local pc.
However, it failed as follows.

[ERROR] Failures: [ERROR] TemplateTest.testToJSONWithVersion:321 expected:<...NODE","updateTime":"[Tue, 08 Dec] 2020 15:49:51 UTC",...> but was:<...NODE","updateTime":"[火, 08 12] 2020 15:49:51 UTC",...> [ERROR] Errors: [ERROR] TemplateTest.testFromJSONWithVersion:250 » IllegalState Unable to parse update... [ERROR] VersionTest.testConstructorWithValidUTCUpdateTime:51 » IllegalState Unable to ... [INFO] [ERROR] Tests run: 1554, Failures: 1, Errors: 2, Skipped: 2 

I thought it was probably a problem with the language settings on my pc, so the language is fixed to en.

$ mvn --version ... omit ... Default locale: ja_JP, platform encoding: UTF-8 ... omit ... 

With this fix, mvn test was successful on my pc.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think a better way to do this is to set the language settings for the maven-suresire-plugin as shown here: https://stackoverflow.com/a/17774592/5190886

@utam0k
Copy link
Author

utam0k commented Feb 27, 2021

Thank you for your comment. I tried changing the following, but it didn't work.

$ git diff diff --git a/pom.xml b/pom.xml index b7e6919..10da5f0 100644 --- a/pom.xml +++ b/pom.xml @@ -60,7 +60,6 @@ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> <skipUTs>${skipTests}</skipUTs> <netty.version>4.1.59.Final</netty.version> - <argLine>-Duser.language=en</argLine> </properties> <scm> @@ -293,6 +292,9 @@ <version>2.22.0</version> <configuration> <skipTests>${skipUTs}</skipTests> + <systemPropertyVariables> + <user.language>en</user.language> + </systemPropertyVariables> </configuration> </plugin> 

I took a look at the link you teach me, and it looks like I may need to pass the language setting when starting the JVM.
https://stackoverflow.com/questions/17774331/maven-default-locale-not-same-with-os-locale#comment113252818_17774592

@lahirumaramba
Copy link
Member

Closing as a workaround is discussed above. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants