Skip to content

Removing toString, hashCode and equals methods from FirebaseOptions #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2017
Merged

Removing toString, hashCode and equals methods from FirebaseOptions #48

merged 1 commit into from
Jun 13, 2017

Conversation

@hiranya911
Copy link
Contributor

  • Removed toString(), hashCode() and equals() methods from FirebaseOptions class. These methods had been originally implemented to support some persistence requirements, which are no longer in use. We can consider adding these methods back if and when we decide to add persistence in the future.
  • Removed the affected test cases.
  • Changed FirebaseApp.toString() to no longer include options in the output.

See #38 for a related discussion
@hiranya911 hiranya911 requested a review from mikelehen June 12, 2017 23:30
@hiranya911 hiranya911 assigned hiranya911 and unassigned mikelehen Jun 13, 2017
@hiranya911 hiranya911 merged commit 359269d into master Jun 13, 2017
@hiranya911 hiranya911 deleted the hkj-options-cleanup branch June 13, 2017 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@hiranya911 @mikelehen