Refactoring the User Management API #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mikelehen suggested changes Jun 3, 2017
| * corresponding to the newly created account. If an error occurs while creating the user | ||
| * account, the task fails with a FirebaseAuthException. | ||
| * @throws NullPointerException if the provided builder is null. | ||
| * @throws NullPointerException if the provided user is null. |
| * | ||
| * @return a user ID string. | ||
| */ | ||
| public String getUid() { |
There was a problem hiding this comment.
Should these be annotated with @ Override?
| * @return a display name string or null. | ||
| */ | ||
| @Nullable | ||
| public String getDisplayName() { |
There was a problem hiding this comment.
Not sure, but I think we still want @ Nullable annotation?
| | ||
| /** | ||
| * Returns a new {@link User.Updater} instance, which can be used to update the attributes | ||
| * Returns a new {@link UpdateRequest}, which can be used to getProperties the attributes |
There was a problem hiding this comment.
silly auto refactor! Fixed :)
| Made the suggested changes. |
| +1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following changes were suggested at the API review:
UserInfopublic interface typeUsertoUserRecordUser.BuildertoUserRecord.CreateRequestUser.UpdatertoUserRecord.UpdateRequestProviderUserInfofrom the public APIUserInfoat bothUserRecordandProviderUserInfoRelated to #33