Add SLF4J-simple dependency for tests execution #230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Without the `slf4j-simple` dependency, log-statements during tests are ignored and the following warning is printed instead: > SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". > SLF4J: Defaulting to no-operation (NOP) logger implementation > SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. The error is documented here too: https://www.slf4j.org/codes.html#StaticLoggerBinder --- Currently: $ mvn verify ------------------------------------------------------- T E S T S ------------------------------------------------------- Running com.google.firebase.iid.FirebaseInstanceIdIT SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.494 sec - in com.google.firebase.iid.FirebaseInstanceIdIT Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 --- With the dependency: $ mvn verify ------------------------------------------------------- T E S T S ------------------------------------------------------- Running com.google.firebase.iid.FirebaseInstanceIdIT Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.536 sec - in com.google.firebase.iid.FirebaseInstanceIdIT Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
| friendly ping |
| I think the existing behavior is acceptable. We certainly don't want to permanently enable logs for tests. If we must turn off the warning, then we should add |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Without the
slf4j-simpledependency, log-statements during testsare ignored and the following warning is printed instead:
The error is documented here too:
https://www.slf4j.org/codes.html#StaticLoggerBinder
--- Currently:
$ mvn verify
T E S T S
Running com.google.firebase.iid.FirebaseInstanceIdIT
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.494 sec - in com.google.firebase.iid.FirebaseInstanceIdIT
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
--- With the dependency:
$ mvn verify
T E S T S
Running com.google.firebase.iid.FirebaseInstanceIdIT
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.536 sec - in com.google.firebase.iid.FirebaseInstanceIdIT
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0