Skip to content

Fixing incomplete javadoc #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2017
Merged

Fixing incomplete javadoc #19

merged 1 commit into from
Apr 21, 2017

Conversation

@hiranya911
Copy link
Contributor

No description provided.

@hiranya911 hiranya911 requested a review from mikelehen April 21, 2017 23:16
mikelehen
mikelehen approved these changes Apr 21, 2017
View reviewed changes
Copy link

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just to double-check, this doesn't end up in our published docs, right? RunLoop used to be a public part of our API, but we eventually made it internal / non-configurable to reduce our surface area.
@hiranya911
Copy link
Contributor Author

No, nothing in the core package gets published in API docs.
@hiranya911 hiranya911 assigned hiranya911 and unassigned mikelehen Apr 21, 2017
@hiranya911 hiranya911 merged commit a115545 into master Apr 21, 2017
@hiranya911 hiranya911 deleted the hkj-fix-comment branch April 21, 2017 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@hiranya911 @mikelehen