Skip to content

Conversation

@hiranya911
Copy link
Contributor

No description provided.

Copy link

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.

this Maven profile by running the following command:

```
mvn site -Ddevsite.template=path/to/templates

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide guidance on what path/to/templates should be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bit more info.

Copy link

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you undo what I asked you to do. :-) [sorry, I forgot we can't point to the right directory to use].

We should separately update (or create?) internal docs to describe how to build / release the SDK and docs, including the right devsite path to use, etc.


The `devsite.template` property should point to a directory consisting of Clearsilver templates
for formatting the API docs. This command will place the generated API docs in the `target/apidocs`
directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. You can probably remove this. I think the above paragraph is already enough. I was hoping we could explicitly point to the right templates to use, but I forgot we can't since this is going to be open source.

Also, in the paragraph you added you say "target/apidocs" but in the previous paragraph it says "target/site/apidocs" so please make sure to keep whichever one is correct. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the extra text. The two plugins use slightly different output locations (target/site/apidocs and target/apidocs). So the instructions are correct.

@hiranya911 hiranya911 merged commit 4954687 into master Apr 20, 2017
@hiranya911 hiranya911 deleted the hkj-doclava-integration branch April 20, 2017 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants