FirebaseApp is expected to return a mutable list of apps; Hiding a co… #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…uple of internal members in Query
mikelehen suggested changes Apr 20, 2017
| // TODO(arondeak): reenable persistence. See b/28158809. | ||
| synchronized (appsLock) { | ||
| return ImmutableList.copyOf(instances.values()); | ||
| return new ArrayList<>(instances.values()); |
There was a problem hiding this comment.
Hrm. I don't think there's any good reason to return a mutable list. Could we just fix the javadoc instead?
There was a problem hiding this comment.
I prefer that too. Changed to ImmutableList and updated the Javadoc to just say returns a "List". User code should not make any assumptions about the behavior of the List we return.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
FirebaseApp is expected to return a mutable list of apps (check the javadoc of the getApp method);
Hiding a couple of internal members in Query (these were missed in the previous PR, and triggers doc build errors if not hidden -- since their return types are already hidden)