Create GitHub Action CI file #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against da378c6 |
AvdLee suggested changes Oct 25, 2021
Package.swift Outdated
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.1 | |||
| // swift-tools-version:5.3 | |||
There was a problem hiding this comment.
Can you try setting this to 5.5?
.github/workflows/swift.yml Outdated
| - run: gem install bundler | ||
| - run: bundle install | ||
| - run: npm install -g danger | ||
| - run: swift package generate-xcodeproj |
There was a problem hiding this comment.
generate-xcodeproj is deprecated. We're now using xcodebuild directly through fastlane scan, which results in the following output:
[13:10:35]: $ set -o pipefail && cd WeTransferPRLinter/ && env NSUnbufferedIO=YES xcodebuild -scheme WeTransferPRLinter -destination 'platform=macOS' -resultBundlePath 'build/reports/WeTransferPRLinter.xcresult' -enableCodeCoverage YES -clonedSourcePackagesDirPath /Users/vagrant/git/.build build test | tee '/Users/vagrant/Library/Logs/scan/WeTransferPRLinter.log' | xcpretty --report junit --output '/var/folders/g2/xnd8hpjs50v433gfrybz2nxh0000gn/T/junit_report20211025-1719-128l68k' In other words, you can skip generating the Xcode project and just use xcodebuild directly on the package
There was a problem hiding this comment.
I knew was deprecated, but didn't know I could use xcodebuild directly, that is pretty cool! thank you :)
| @f-meloni what is the status of this? Our tests are still failing using the Danger master branch :( |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.