Remove legacy exception handlers #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
KeyError and TypeError are very generic and might point to an error in the method implementation rather than in the client. The new exceptions MethodNotFoundError and InvalidArgumentsError avoid these issues, so there is no need to catch the generic ones anymore. This effectively changes method behavior if methods raise KeyErrors and/or TypeErrors.
| Actually have removed KeyError in 4.1.0, because it wasn't part of the library's api so it's not a breaking change. |
| Ok, even better! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
KeyError and TypeError are very generic and might point to an error in
the method implementation rather than in the client. The new exceptions
MethodNotFoundError and InvalidArgumentsError avoid these issues, so
there is no need to catch the generic ones anymore. This effectively
changes method behavior if methods raise KeyErrors and/or TypeErrors.
As pointed out previously, it is debatable whether to keep catching
AssertionErrors as they can be used to check simple server invariants rather than method arguments, too.