Updated method of logging exceptions in Request.process #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Exceptions raised while calling a method in Request.process were being logged using just the logging utiliy, which relied on a logging handler being defined. In the event a logging handler is not defined and an exception is raised while calling a method, an error about the lack of a logging handler is raised, and the original exception is never logged. This change makes use the _log utility, which takes into account situations where a logging handler is not defined. In the scenario described before, a stacktrace of the initial error is logged as expected.
| Good pickup, thanks |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Exceptions raised while calling a method in Request.process were being logged using just the logging utility, which relied on a logging handler being defined. In the event a logging handler is not defined and an exception is raised while calling a method, an error about the lack of a logging handler is raised, and the original exception is never logged.
This change makes use of the _log utility, which takes into account situations where a logging handler is not defined. In the scenario described before, a stacktrace of the initial error is logged as expected.