Ensure py.typed is included in the source distribution. #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Now that I think about it, I'm a bit confused about this because I thought setuptools will always include any files listed in |
| Thanks @embray , just FYI master branch in this repo is the upcoming version 5 which is a couple months away. We should probably make the same change in the 4.x branch which is the latest stable version. |
| @bcb Thanks. Do you want me to make a backport PR? |
| That would be great thank you 🙏 |
| Done, sorry for the delay: #160 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It's not included by setup.py sdist if not listed in MANIFEST.in.
Same problem for
jsonrpcclient.