Close the resources in case there was an exception #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ZipFile requested changes Dec 8, 2024
| | ||
| | ||
| cdef bint _isawaitable(object instance): | ||
| cdef bint _is_awaitable(object instance): |
There was a problem hiding this comment.
This change looks unrelated to the main topic of PR. Please revert to avoid diff noise.
| result = fn(*args, **to_inject) | ||
| try: | ||
| return fn(*args, **to_inject) | ||
| finally: |
There was a problem hiding this comment.
We need a test case to verify that this code block now is always executed.
| to_inject[injection] = provide | ||
| try: | ||
| return await fn(*args, **to_inject) | ||
| finally: |
There was a problem hiding this comment.
We no longer store generated C files in source tree. Rebasing with latest master should no longer produce merge conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have the same problem as in #681: the resources are not closed in case functions are failing, and I have my exceptions handler on a higher level then functions I inject.
So I suggest the change to close the dependencies in any case.