Skip to content

Conversation

@canyon289
Copy link
Contributor

@ericmjl Let me know if editing the notebooks to include ArviZ is still welcome. If so let me know if you'd like me to do a PR per notebook, or all in one shot.

And if its not no worries :)

@ericmjl
Copy link
Owner

ericmjl commented Jan 19, 2019

@canyon289 this is still welcome! I think one PR per notebook might be easier to manage, what do you think?

@ericmjl
Copy link
Owner

ericmjl commented Jan 19, 2019

Also, do ping me when you think this is ready! I have enabled the WIP bot, I'll first mark this as WIP in the title; when done, you can just remove it.

@ericmjl ericmjl changed the title Add ArviZ to to env and 02-Instructor WIP Add ArviZ to to env and 02-Instructor Jan 19, 2019
@ericmjl ericmjl changed the title WIP Add ArviZ to to env and 02-Instructor Add ArviZ to to env and 02-Instructor (WIP) Jan 19, 2019
@ericmjl
Copy link
Owner

ericmjl commented Jan 19, 2019

By the way, @hugobowne, please meet @canyon289! 😄

@canyon289
Copy link
Contributor Author

@ericmjl one at a time is fine. It makes is easier to review and iterate

@hugobowne Nice to meet you as well!

@canyon289
Copy link
Contributor Author

This one is ready for review

@hugobowne
Copy link
Collaborator

Thanks @canyon289 & great to meet you also. It will take me ~2 weeks to get to this as currently on vacation w/out computer (I know!) 🤣

@ericmjl ericmjl changed the title Add ArviZ to to env and 02-Instructor (WIP) Add ArviZ to to env and 02-Instructor Jan 20, 2019
@ericmjl
Copy link
Owner

ericmjl commented Jan 20, 2019

@hugobowne I looked over the rest of the PR series by @canyon289, and I think we're good to merge - review unnecessary! I'll also be setting up some automation to get the notebooks published nicely as a GitHub pages website.

@ericmjl ericmjl merged commit 464d193 into ericmjl:master Jan 20, 2019
ericmjl added a commit that referenced this pull request Jan 21, 2019
Add ArviZ to to env and 02-Instructor
ericmjl added a commit that referenced this pull request Jan 21, 2019
Add ArviZ to to env and 02-Instructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants