Fixes issues of unsafe memory access #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #15 +/- ## ========================================== + Coverage 98.49% 98.57% +0.07% ========================================== Files 3 3 Lines 266 280 +14 ========================================== + Hits 262 276 +14 Misses 4 4
Continue to review full report at Codecov.
|
eric-wieser reviewed Sep 10, 2020
Comment on lines +174 to +175
| item_arr = ((item_arr + self._left_index) | ||
| % self._right_index) |
Owner
There was a problem hiding this comment.
This looks wrong to me for cases when left_index != 0
Author
There was a problem hiding this comment.
test_append causes the buffer to wrap, which makes self._left_index be greater than 0, and it passes
fpdotmonkey changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds the tests
test_raises_error_indexing_empty_bufferandtest_negative_indices_give_recent_data_with_unfull_bufferto ensure the class doesn't access memory unsafely.Closes #13 Closes #14