adding django6.0b1 support #9819
Conversation
| Removing |
| @auvipy please review this PR ! |
auvipy requested review from auvipy and Copilot and removed request for auvipy There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Django 6.0 beta testing and fixes compatibility issues with Django 6.0 changes. The key changes are:
- Adding Django 6.0 beta to the test matrix for Python 3.12 and 3.13
- Fixing a test compatibility issue with Django 6.0's
values_list()behavior - Adjusting a URL validation test for changes in Django's URL handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tox.ini | Adds Django 6.0 beta (6.0b1) to the test environment matrix for py312 and py313 |
| tests/test_validators.py | Fixes values_list() call to explicitly specify 'id' field for Django 6.0 compatibility |
| tests/test_templatetags.py | Adds URLIZE_ASSUME_HTTPS=True setting and removes a URL test case incompatible with Django 6.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "www.as_df.org", | ||
| "as.d8f.ghj8.gov", | ||
| ] | ||
| if django.VERSION < (5, 3): |
There was a problem hiding this comment.
we should keep this check for a while
There was a problem hiding this comment.
Should we wait for 6.0b2 to be released? At that point we should no longer need it (there was a regression in Django, which has been fixed now)
There was a problem hiding this comment.
we can wait bor dj b2 or rc1. yes I saw the fix for the regression.
There was a problem hiding this comment.
@browniebroke I ran the tests against main branch, But still showing Incorrect url. Idk why this is happening.
There was a problem hiding this comment.
OK I checked it. It is passing for django main now. failing for django6.0b1. Thanks.
There was a problem hiding this comment.
it will be backported to 6.0.x soon
3 participants
No description provided.