fix: do not generate params for requests if its specified as `none' #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wkirschbaum force-pushed the main branch 5 times, most recently from e5f11f9 to 0789eac Compare wkirschbaum changed the title 
wkirschbaum commented Jul 11, 2023
priv/request.ex.eex Outdated
| field :jsonrpc, String.t(), default: "2.0" | ||
| field :id, integer(), enforce: true | ||
| field :params, <%= LSPCodegen.Codegen.to_string(@params, @metamodel) %> | ||
| <%= unless @params == :none do %> field :params, <%= LSPCodegen.Codegen.to_string(@params, @metamodel) %> <% end %> |
Contributor Author
There was a problem hiding this comment.
not sure if there is a way to have the condition on separate lines without forcing a space.
* lib/lsp_codegen/request.ex (new/1): Update condition to identify a missing :params key. * priv/request.ex.eex: Add condition for :none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When the params is none, the client might send an empty map or map, depending on protocol version. It does not really matter which type we get as it won't be used. This will move towards resolving: elixir-tools/gen_lsp#30