Updated core files #20
Conversation
| * There's this weird thing where facet values for dates come back as an integer | ||
| * from the API, but the API expects them as parameters formatted as date | ||
| * strings. | ||
| * Facet values for dates come back as Integer from the API. However, the API |
src/search-lib/SearchDriver.js Outdated
| * Configuration for Facet filters to be used within this application. The | ||
| * syntax for Facet configuration follows the API syntax: | ||
| * https://swiftype.com/documentation/app-search/api/search/facets. In | ||
| * https://swiftype.com/documentation/search-lib/api/search/facets. In |
There was a problem hiding this comment.
This was mistakenly edited during the replace all. :)
There was a problem hiding this comment.
Oh geez, good catch 🤦♂️
src/search-lib/SearchDriver.js Outdated
| * This is low level configuration which lets you configure | ||
| * the options used on the Search API endpoint, ex: `result_fields`. | ||
| * https://swiftype.com/documentation/app-search/api/search | ||
| * https://swiftype.com/documentation/search-lib/api/search |
| * engineName - Engine to query, found in your App Search Dashboard | ||
| * hostIdentifier - Credential found in your App Search Dashboard | ||
| * searchKey - Credential found in your App Search Dashboard | ||
| * endpointBase - (optional) Overrides the base of the Swiftype API endpoint |
JasonStoltz force-pushed the updates-after-elastic-co branch from 0707606 to 50d46b5 Compare 
| @goodroot Read for re-review |
| After implementing search on Elastic.co, there were a number of things that I added to the "core" files, that would be good to add here. The "core" files here are a set of files which act as a "library" which will eventually be abstracted out into the UI Toolkit. The Reference UI should act as the source of truth for that code until then. Since search on Elastic.co essentially used a copy of those files from this project, it would be ideal to commit those changes back to the Reference UI. Some of this behavior I'm committing back is not actually used in the Reference UI. However, if someone were to use this application as a starting point, it would benefit them to have that additional behavior available for use. Updates include:
There will be slight functional differences in the application:
|
Note for reviewers: Reviewing the individual commits will provide a cleaner diff, since in the main diff some files are shown as new, rather than moved.
After implementing search on Elastic.co, there were a number of things that I added to the "core" files, that would be good to add here.
The "core" files here are a set of files which act as a "library" which will eventually be abstracted out into the UI Toolkit. The Reference UI should act as the source of truth for that code until then. Since search on Elastic.co essentially used a copy of those files from this project, it would be ideal to commit those changes back to the Reference UI.
Some of this behavior I'm committing back is not actually used in the Reference UI. However, if someone were to use this application as a starting point, it would benefit them to have that additional behavior available for use.
Updates include:
/app-searchto/search-liband created an index.js file to make it feel more like a library rather than additional app code.clearFiltersandsetFilterThere will be slight functional differences in the application: