Skip to content

Conversation

@JasonStoltz
Copy link
Member

This will enable local development of the Reference UI as well as staging deploys.
Also fixed an issue with an npm package.

This will enable local development of the Reference UI as well as staging deploys.
@JasonStoltz JasonStoltz requested a review from jgr September 26, 2018 15:15
Copy link
Contributor

@jgr jgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

* trackURLState - Boolean, track state in the url or not?
*/
constructor({
endpointBase = "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming empty string means production further down the stack?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's effectively what it would mean, yes.

@jgr jgr merged commit 75a4f1c into master Sep 27, 2018
@JasonStoltz JasonStoltz deleted the endpointBase-config branch September 9, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants