Skip to content

Conversation

@webflo
Copy link
Member

@webflo webflo commented Nov 9, 2018

@webflo
Copy link
Member Author

webflo commented Nov 9, 2018

@webflo
Copy link
Member Author

webflo commented Nov 9, 2018

New files, with fixed logic for contrib.

d8-composer.json.txt
d7-composer.json.txt

@weitzman
Copy link
Collaborator

LGTM. We plan to merge this when next Drush release happens.

@weitzman
Copy link
Collaborator

weitzman commented Jan 8, 2019

It would very helpful if we could merge this into a new 8.y branch or some other named branch. Any chance we can setup Circle to publish like that? Then I could point Drush9 to that branch. Right now, pm:security is broken with Drush9.


public static function handleCore($version) {
list($major, $minor) = explode('.', $version);
return ">=$major.$minor,<$version";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For D7, this returns constraints like >7.67,<=7.67 instead of >7,<=7.67, so a different return is needed

 public static function handleCore($version) { list($major, $minor) = explode('.', $version); if ($major == '7') { return ">=$major,<$version"; } return ">=$major.$minor,<$version"; } 
@webflo
Copy link
Member Author

webflo commented Sep 25, 2019

Created branch build-v2 with this code and configured Circle CI similar to the master branch. https://github.com/drupal-composer/drupal-security-advisories/tree/build-v2

The build was successful a few minutes ago.

@gapple Pleas open a new issue for D7 builds with v2 Version scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants