Skip to content

Conversation

@sei40kr
Copy link
Contributor

@sei40kr sei40kr commented Feb 7, 2020

Description

  • Add const
  • Add if
  • Add ife
  • Set snippet key for all Go snippets
  • Fix some snippet placeholders
  • Remove ifunc
@sei40kr sei40kr requested a review from hlissner February 7, 2020 15:57
@sei40kr sei40kr force-pushed the go-snippets branch 2 times, most recently from 994520d to 55de3ae Compare February 7, 2020 15:58
Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove explicit keys that match the name of the file. Yasnippet uses the filename if key is omitted, and since they all match their given keys, they were omitted intentionally.

@sei40kr
Copy link
Contributor Author

sei40kr commented Feb 8, 2020

@hlissner
Sorry I've been having an wrong idea for Yasnippet keys.
I've updated the PR. Please review 🙇

@sei40kr sei40kr requested a review from hlissner February 8, 2020 06:31
@hlissner hlissner merged commit e461cc7 into doomemacs:master Feb 9, 2020
@hlissner
Copy link
Member

hlissner commented Feb 9, 2020

No problem! Thanks for the quick response and for all your help, here and for Doom!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2 participants