New MySQLPDOLock class on NinjaMutex and MySQL driver with options #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi @rafacouto, Thank you for your contribution! I'll try to take a look at it soon (hopefully this weekend). |
Codecov Report
@@ Coverage Diff @@ ## master #28 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 23 23 =========================================== Files 2 2 Lines 58 60 +2 =========================================== + Hits 58 60 +2
Continue to review full report at Codecov.
|
| Looks good, thanks 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR allows to use the mysql strategy and set options with the PDO driver.
It was motivated by the need of connecting to a MySQL/MariaDB server with the SSL/TLS option required. If that option is rightly configured in your Laravel's database config this patch uses the database.connections.mysql.options setup transparently.
NinjaMutex master branch is required to pass the options parameter. Last release of arvenil/mutex at this PR moment is 0.6 so that composer dependency is dev-master#82cbb2c (Feb 1, 2021). If a new release of NinjaMutex is published it should be set on this composer.json.