Skip to content

Update WithoutOverlapping.php #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update WithoutOverlapping.php #18

wants to merge 1 commit into from

Conversation

@vafir
Copy link

@vafir vafir commented Oct 11, 2019

No description provided.

@dmitry-ivanov
Copy link
Owner

Thanks for the PR, but I'll close it because:

  1. Tests are failing.
  2. I think it's better to have a separate log file for each of the console commands. It's much more convenient, and in that case, you'll immediately know which command was stopped by mutex.

Check the illuminated/console-logger package which does particularly that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vafir @dmitry-ivanov