Skip to content

Conversation

@djmaxus
Copy link
Owner

@djmaxus djmaxus commented Jun 16, 2025

  • replace rmdir with remove_directory wrapper function
  • improve error handling for late template adoption cases
- replace rmdir with remove_directory wrapper function - improve error handling for late template adoption cases
@djmaxus djmaxus added this to the Hands-on Workshop milestone Jun 16, 2025
@djmaxus djmaxus self-assigned this Jun 16, 2025
Copilot AI review requested due to automatic review settings June 16, 2025 11:00
@djmaxus djmaxus added bug Something isn't working enhancement New feature or request labels Jun 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling within the initialization routines and replaces direct calls to rmdir with a new remove_directory wrapper function.

  • Replaces rmdir calls with a remove_directory function that wraps the removal process.
  • Updates error conditions in functions (reset_file, set_license, reset_cff) to emit warnings instead of errors for better late template adoption handling.
Comments suppressed due to low confidence (2)

init.m:115

  • Replacing a fatal error with a warning may lead to silent failures downstream. Consider returning an explicit error status or message so that calling functions can handle the failure appropriately.
warning(['Could not open ', name,' for writing: ',err_msg]); 

init.m:77

  • [nitpick] There are TODO comments remaining in the diff. It would be beneficial to either address these comments or create corresponding issues to ensure they are not overlooked in the future.
remove_directory('.github/actions'); 
djmaxus added 3 commits June 16, 2025 12:07
Because this workflow is very slow in practice
A workaround to preserve the cache
Trying to improve reliability and speed.
@djmaxus djmaxus merged commit 574b13d into main Jun 16, 2025
9 checks passed
@djmaxus djmaxus deleted the release-artifact-test branch June 16, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

2 participants