node move permission fix #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
akermen commented Jan 9, 2019
akermen commented - 'app_label' added to match the permission codenames
- instance parameter 'moved' removed from the permission check because default Django implementation of object level permisson backend returns 'False' even (non-admin) user has change permission for that object type
- 'app_label' added to match the permission codenames - instance parameter 'moved' removed from the permission check because default Django implementation of object level permisson backend returns 'False' even (non-admin) user has change permission for that object type
Codecov Report
@@ Coverage Diff @@ ## master #70 +/- ## ======================================= Coverage 64.91% 64.91% ======================================= Files 12 12 Lines 761 761 ======================================= Hits 494 494 Misses 267 267
Continue to review full report at Codecov.
|
vdboor force-pushed the master branch 3 times, most recently from cc3e02a to e6d75ef Compare 
| thanks! sorry for missing this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.