Skip to content

Conversation

@jpotterm
Copy link
Contributor

Grappelli has recently changed grp-container from an ID to a class: sehmaschine/django-grappelli@9eaca21

So this brings django-polymorphic-tree in line with that change.

@vdboor vdboor merged commit dfa9eb4 into django-polymorphic:master Apr 7, 2016
@vdboor
Copy link
Member

vdboor commented Apr 7, 2016

Good to know, thanks for adding this!

@vdboor
Copy link
Member

vdboor commented Apr 7, 2016

@jpotterm can you tell me which release this happens in? I notice the current master doesn't show this:

https://github.com/sehmaschine/django-grappelli/search?utf8=%E2%9C%93&q=grp-container

@jpotterm
Copy link
Contributor Author

jpotterm commented Apr 8, 2016

@vdboor
Copy link
Member

vdboor commented Apr 11, 2016

Ah, ok! From what I see, the 2.8.1 release solves it differently: https://github.com/sehmaschine/django-grappelli/blob/2.8.1/grappelli/templates/admin/base.html - it gives the element 2 ID's. I've reverted the commit for now, as the current release would be incompatible otherwise. however, it it pops up with a different release, please let me know!

@jpotterm
Copy link
Contributor Author

@vdboor Yes 2.8.1 did it that way, but that actually breaks the functionality entirely because elements are only allowed to have one ID (see sehmaschine/django-grappelli#741). So it's impossible to keep compatibility with 2.8.1 since the #grp-container selector won't match at all.

So I figure we might as well adopt the new functionality now, since both ways (#grp-container and .grp-container) are broken in 2.8.1 but the new way will work in the next release.

@vdboor
Copy link
Member

vdboor commented Apr 13, 2016

I see. We might be able to use #container now, as the file is only loaded with grappelli installed - that should work regardless of the grappelli version,

@jpotterm
Copy link
Contributor Author

That's true, that would probably work. Either way, I don't think it's a huge deal to miss a single grappelli release especially since it's grappelli's fault that they broke compatibility in a bugfix release. But yeah, whatever you want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants