- Notifications
You must be signed in to change notification settings - Fork 31
docs: Deduplication and clarity in the tutorials #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR reorganizes tutorial content to reduce duplication and improve clarity by centralizing installation steps, refining tutorial introductions, standardizing terminology, and applying minor editorial fixes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review: ## Individual Comments ### Comment 1 <location> `docs/source/tutorial/index.rst:20-21` </location> <code_context> added to your project's ``INSTALLED_APPS``. 2. **Template Components** – The easiest approach creating or porting your own - **custom frontend components**, allowing you define components by their HTML templates. Special + custom components, allowing you to define them by their **HTML templates, without any code**. Special ``djangocms-frontend`` tags are used to provide the additional declarative information needed. This is the fastest approach to create ``djangocms-frontend`` components. </code_context> <issue_to_address> **issue (typo):** Missing 'to' after 'approach' in the sentence. Change the sentence to: 'The easiest approach to creating or porting your own custom components...'. ```suggestion 2. **Template Components** – The easiest approach to creating or porting your own custom components, allowing you to define them by their **HTML templates, without any code**. Special ``` </issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| I renamed the tutorials as suggested in #312 (comment). In the end I'm not doing any name changes in this PR, which is already getting tricky to review. I suggest we do in a followup if we want to change the name of custom (CMS) components to form-based components. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #317 +/- ## ======================================= Coverage 89.00% 89.00% ======================================= Files 124 124 Lines 3383 3383 Branches 287 287 ======================================= Hits 3011 3011 Misses 256 256 Partials 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fsbraun left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marbru Thank you for the great work! Thanks for taking the time to look at many details!!
The main motivation of this PR comes from this ticket: #312 To a newcomer, it looks like if the template components tutorial and custom component tutorial are both the same. There's full explanation of the reasons for this confusion in the ticket.
This PR implements some changes that hopefully will make things clearer and less confusing for newcomers:
builtin_components.rsttutorial, which has also been renamed to "Installation and usage with built-in components". This is more descriptive, plus marks it as the obvious starting point.-
template_components.rstandcustom_components.rsthave been given more descriptive titles, and introductore text has been changed from a generic description of the benefits of custom components to a description of the particularities of the type of component covered in the tutorial.For followup: the renaming of
custom componentstoform-based components(proposed in this discussion is intentionally not included in this PR, in order to limit the scope of the changes. If we want it, I suggest to be done in a followup PR, where changes can be reviewed in isolation.