Pin svglib to a version below 1.6.0 (#1550) #1551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…jango-cms#1550) The latest svglib release (1.6.0) has introduced a new dependency on pycairo, which requires system-level libraries to install correctly. This change causes the installation of easy-thumbnails[svg] to fail in environments where these libraries are not present. This commit pins svglib to version 1.5.1 as a temporary workaround until the upstream issue is resolved. Ref: deeplook/svglib#421
…with pyproject-flake8
| @payamnj Sorry for being late on the review. Could you please address one minor comment and then we are good to go here. Thank you for your contribution to @django-cms. Also, could you please add this pinning of requirement in the readme. It would be great for folks installing this to know why this change was done. Thank you!! |
vinitkumar requested changes Oct 23, 2025
| | ||
| - repo: https://github.com/PyCQA/flake8 | ||
| rev: 7.3.0 | ||
| rev: 7.0.0 |
There was a problem hiding this comment.
The upgrade has actually broken the build in the master branch. This is because incompatibility between the flake8 and pyproject-flake8.
I downgrade it so the build can pass, but maybe it should be handled with another issue and PR! I am not sure which is better, but before we fix the master branch build we can not merge other PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.