Skip to content

Reaction class should use Emoji Part rather than stdClass #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
valzargaming wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reaction class should use Emoji Part rather than stdClass #1422

valzargaming wants to merge 2 commits into from

Conversation

@valzargaming
Copy link
Member

@valzargaming valzargaming commented Oct 15, 2025

This pull request makes a minor improvement to the Reaction class in the Discord package by initializing the emoji attribute with an Emoji object instead of a generic stdClass. This change enhances type safety and consistency when handling emoji data.

  • Improved emoji initialization:
    • In the setIdAttribute method of Reaction.php, replaced the initialization of the emoji attribute from a stdClass to an Emoji object for better type safety and clarity.
    • Removed the unused stdClass import from Reaction.php.
@valzargaming valzargaming requested a review from a team October 15, 2025 19:47
@valzargaming valzargaming changed the title Update Reaction.php Reaction class should use Emoji Part rather than stdClass Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@valzargaming