Initialize mOriginUs lazily #167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @natario1 |
natario1 approved these changes Mar 12, 2022
| Hello @jumperson I have tried the changes from the fork and transcoding a video with the In my case any video downloaded from TikTok produces that issue on an Android 12 device. |
| Hello @tudormarze. |
| I cherry-picked your commit and improved a bit on it in #200 . Thanks a lot for your investigation @jumperson , this must have been very hard to catch. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have same issue.
I checked the diffs for v0.9.1 and v0.10.0 and found that there was an issue at natario1@997de45 .
After proceeding with the verification, it seems that some terminals have side effects with
mExtractor.selectTrack(i)andmExtractor.unselectTrack(i).Therefore, I changed the timing to set
mOriginUs.