Skip to content

fix FilePathDataSource crash before initialize. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2022
Merged

fix FilePathDataSource crash before initialize. #160

merged 1 commit into from
Mar 12, 2022

Conversation

tateisu
Copy link
Contributor

@tateisu tateisu commented Dec 24, 2021 •
edited
Loading

I'm experienced bug about FilePathDataSource on varsion 0.10.4:

  • use addDataSource(filePath)
  • start transcode()
  • DataSources.init() calls FilePathDataSource.isInitialized()
  • DataSourceWrapper.isInitialized does not check null of mSource.
@jumperson
Copy link
Contributor

jumperson commented Dec 24, 2021 •
edited
Loading

May be fix #154
@jumperson jumperson mentioned this pull request Jan 14, 2022
Merged
natario1
natario1 approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@natario1 natario1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
@natario1 natario1 merged commit 8627643 into deepmedia:main Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@tateisu @jumperson @natario1