This repository was archived by the owner on May 17, 2024. It is now read-only.
Mark data-diff as type-annotated #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The type annotations are incomplete and sometimes simply wrong. But at least they are annotated _somehow_, partially. More importantly, we have numerous simple classes & `attrs` classes, which could be used for type-checking properly without inferring them as `Any` — e.g., in structural pattern matching, such as `match col: case NumericType(precision=0): …`. Proper type annotations and strict-mode MyPy checking will arrive later, eventually (it is a work in progress, just not a priority).
vvkh approved these changes Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The type annotations are incomplete and sometimes simply wrong. But at least they are annotated somehow, partially. More importantly, we have numerous simple classes &
attrsclasses, which could be used for type-checking properly without inferring them asAny— e.g., in structural pattern matching, such asmatch col: case NumericType(precision=0): ….Proper type annotations and strict-mode MyPy checking will arrive later, eventually (it is a work in progress, just not a priority).