<No Merge> Data diff fork compare #66
Conversation
| snowflake = import_snowflake() | ||
| logging.getLogger("snowflake.connector").setLevel(logging.WARNING) | ||
| | ||
| with open("/Users/sfenner/.ssh/snowflake_rsa_key.p8", "rb") as key: |
There was a problem hiding this comment.
perhaps there is a more generic way to do this type of thing......
| | ||
| class Presto(Database): | ||
| def __init__(self, host, port, database, user, password): | ||
| def __init__(self, host, port, user, password, schema, database, print_sql=True): |
There was a problem hiding this comment.
maybe we can update this signature to pass in "extra" args, then pass those extra args to prestodb.dbapi.connect might be a lighter weight change.
There was a problem hiding this comment.
I think excess kw should just be passed straight to the driver, also where we'd pass paths, etc. in the absence of a config file (so far)
| try: | ||
| role = dsn.query['role'] | ||
| except KeyError: | ||
| raise ValueError(f"Must provide role. Expected format: '{HELP_SNOWFLAKE_URI_FORMAT}'") |
There was a problem hiding this comment.
Does the Snowflake constructor throw a similar error? I assume it is ok with out one for users that have a default role assigned.
That isn't true in our case and we'd like to pass that along, but maybe isn't quite the same as the other objects like warehouse, database, and scheme....... Not sure.
| from runtype import dataclass | ||
| | ||
| from .sql import Select, Checksum, Compare, DbPath, DbKey, DbTime, Count, TableName, Time, Min, Max, ColumnName | ||
| from .sql import Select, Checksum, Compare, DbPath, DbKey, DbTime, Count, TableName, Time, Min, Max, ColumnName, Compiler |
There was a problem hiding this comment.
I don't see Compiler used in this file. We should take this out.
| @property | ||
| def _relevant_columns(self) -> List[str]: | ||
| extras = set(map(ColumnName, self.extra_columns)) | ||
| extras = set(self.extra_columns) |
There was a problem hiding this comment.
I am not clear on what we wanted to move this map(ColumnName part to latter in the function, can you clarify?
| def compile(self, c: Compiler): | ||
| compiled_exprs = ", ".join(c.database.to_string(s) for s in map(c.compile, self.exprs)) | ||
| expr = f"concat({compiled_exprs})" | ||
| compiled_exprs_raw = [c.database.to_string(s) for s in map(c.compile, self.exprs)] |
There was a problem hiding this comment.
Could you provide an example here or in the description of what prompted this change?
4 participants
Comparing across forks, not to merge