Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

@erezsh
Copy link
Contributor

@erezsh erezsh commented Feb 27, 2023

Fixes Issue #412

@erezsh
Copy link
Contributor Author

erezsh commented Feb 27, 2023

@dlawin Any idea why these tests are failing?

@dlawin
Copy link
Contributor

dlawin commented Feb 27, 2023

@dlawin Any idea why these tests are failing?

Hopefully it's clear from this: 21804e5

Need to use the mock_self as the mock, since that's how the methods are being called now. No need to mock the package (and a package level mock won't override the self.blah methods now)

@dlawin
Copy link
Contributor

dlawin commented Feb 27, 2023

@dlawin Any idea why these tests are failing?

Hopefully it's clear from this: 21804e5

Need to use the mock_self as the mock, since that's how the methods are being called now. No need to mock the package (and a package level mock won't override the self.blah methods now)

I can fix the remaining ones later today

@erezsh
Copy link
Contributor Author

erezsh commented Feb 28, 2023

@dlawin Nice, thank you!

@erezsh erezsh merged commit fb0d8e6 into master Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants