Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

@erezsh
Copy link
Contributor

@erezsh erezsh commented May 25, 2022

No description provided.

@erezsh erezsh requested a review from sirupsen May 25, 2022 13:46
Copy link
Contributor

@sirupsen sirupsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and suggestions, but if this block you tomorrow, you can merge and address in follow-ups

@erezsh
Copy link
Contributor Author

erezsh commented May 26, 2022

I think both comments have a point, and it's not really blocking either way. Let's resolve it properly.

@erezsh erezsh requested a review from sirupsen May 28, 2022 10:21
@erezsh erezsh merged commit 4af05c4 into master May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants