Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Test extending alphanumerics #355

Closed
wants to merge 3 commits into from
Closed

Test extending alphanumerics #355

wants to merge 3 commits into from

Conversation

@erezsh
Copy link
Contributor

@erezsh erezsh commented Dec 21, 2022

No description provided.

@RoderickJDunn
Copy link
Contributor

Hello! I'd be interested in understanding the context/plans for this PR. We have several tables containing a period in their PK string column, so these currently can't be diffed.
@RoderickJDunn RoderickJDunn mentioned this pull request Feb 13, 2023
Closed
@erezsh
Copy link
Contributor Author

erezsh commented Feb 13, 2023

The plans are to ensure that this change doesn't break or significantly reduces performance for regular alphanumeric columns.

Once we verify this, ideally through our own tests, but I would also be satisfied by accounts of several users who tried it and reported back, I'll feel comfortable merging it in.
@github-actions
Copy link
Contributor

This pull request has been marked as stale because it has been open for 60 days with no activity. If you would like the pull request to remain open, please comment on the pull request and it will be added to the triage queue. Otherwise, it will be closed in 7 days.
@github-actions github-actions bot added the stale Issues/PRs that have gone stale label May 16, 2023
@github-actions
Copy link
Contributor

Although we are closing this pull request as stale, it's not gone forever. PRs can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.
@github-actions github-actions bot closed this May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

stale Issues/PRs that have gone stale

3 participants

@erezsh @RoderickJDunn