Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

@erezsh
Copy link
Contributor

@erezsh erezsh commented May 23, 2022

No description provided.

@erezsh erezsh requested a review from sirupsen May 23, 2022 22:33
run_sql("""
INSERT INTO data_diff.rating(id, userid, movieid, rating, timestamp)
SELECT row_number() over (order by userid, movieid, timestamp) AS id, userid, movieid, rating, timestamp FROM data_diff.tmp_rating
""")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

commit()
} else if (db_type == "bigquery") {
print "Importing the CSV through the Python script (BigQuery)"
PY("0", "import _bq_import_csv")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense... would still love for all this to be in Preql, but it's getting better every PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's getting better every PR

Well, that's what PRs are for :)

@erezsh erezsh merged commit d5b465e into master May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants