This repository was archived by the owner on May 17, 2024. It is now read-only.
Support for UUID key column #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sirupsen reviewed Jun 28, 2022
There was a problem hiding this comment.
Nice! This is a really elegant implementation. The direction definitely looks good to me
Would love to see those type tests you mentioned in the opening description to make sure it behaves. Probably we can have a UUIDFaker or something. We might need both a "string" and "uuid" type category to test this there?
sirupsen approved these changes Jun 28, 2022
| @sirupsen This PR is ready. I added a few more changes, but nothing too surprising. Still, thought I'd give you a chance to review it. |
sirupsen approved these changes Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently only working for MySQL, but I'm posting it for comments about my approach and choices.
Next steps would be to -
Add more tests. Maybe into test_database_types
Support more databases and column types.